Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provide low cost means of lines not colliding until they converge #191

Merged
merged 4 commits into from
Nov 28, 2019

Conversation

robertleeplummerjr
Copy link
Contributor

Before:
Screen Shot 2019-11-27 at 3 59 31 PM

After:
Screen Shot 2019-11-27 at 4 01 03 PM

@adrai
Copy link
Owner

adrai commented Nov 27, 2019

You are awesome!
I will merge, but can you first look at why the example flowchart is now rendering strange?
image
npm start and open http://localhost:8000/

And perhaps also test the charts here: https://flowchart.js.org/

btw: can you add here some screenshots of some typical example, how they change?

@robertleeplummerjr
Copy link
Contributor Author

Yup, resolving.

@adrai
Copy link
Owner

adrai commented Nov 27, 2019

hehe... no rush... 😉
already late here... will be back tomorrow

@robertleeplummerjr
Copy link
Contributor Author

fixed

@robertleeplummerjr
Copy link
Contributor Author

Before:
image

After:
image

Before:
image

After:
image

Before:
image

After:
image

@robertleeplummerjr
Copy link
Contributor Author

For my purposes, this is what I saw.

Before:
image

After:
image

@robertleeplummerjr
Copy link
Contributor Author

The main fix was for connections between "Thing 3" and "Thing 4", I found that the layout engine was resilient enough to know how to layout the "Things" (pun intended) if I severed this connection, but when there were doubled + connections beside each other, it caused the weird overlapping issue. of the green and black. But by adding a feature that was smart enough to count the connections and offset for them, it'd fix this.

FYI.

@adrai adrai merged commit 04fd83c into adrai:master Nov 28, 2019
@adrai
Copy link
Owner

adrai commented Nov 28, 2019

You're great!
This is now included in v1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants