Update build tags and error checking to Go 1.18 standards #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Rican7. Thank you for the PR. Can you drop the changes in |
No problem!
Sure! Let me rebase and remove inapplicable changes. |
os.IsExist doesn't handle all types of errors, and while I'm not sure exactly why some of these checks are here, or if they need to exist, using the `errors.Is` should cover more bases. See the `os.IsExist` function comment (https://pkg.go.dev/os#IsExist).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 7 -1
Lines 383 307 -76
=========================================
- Hits 383 307 -76 ☔ View full report in Codecov by Sentry. |
adrg
changed the title
|
@adrg Awesome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the fantastic library!
I'm using it in my define app and I noticed, when looking through the source to understand how it worked in a couple of situations, that the library was using some older Go functions and tags.
So, I stopped by to implement in this PR that:
os.IsExisttoerrors.Isos.IsExistdoesn't handle all types of errors, and while I'm not sure exactly why some of these checks are here, or if they need to exist, using theerrors.Isshould cover more bases. See theos.IsExistfunction comment for more info.go fix ./...Updates the GitHub CI workflow to use Go 1.19. This matches the version defined in thego.mod.