Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Translucent Image Blur #58

Merged
merged 41 commits into from
Feb 17, 2022
Merged

Feature: Translucent Image Blur #58

merged 41 commits into from
Feb 17, 2022

Conversation

adrian-miasik
Copy link
Owner

@adrian-miasik adrian-miasik commented Feb 16, 2022 •
edited

Intended to be used for our confirmation dialog popup. More information coming soon, check back later...

TODO:

  • Acquire license & asset
  • Read documentation
  • Download and import assets
  • Create test bed scene / sample
  • Dev Implementation
  • Test on target platforms
  • Remove bloat / additional files / extras
  • Organize file structure
  • Review
  • Create asset usage document for unity-pomodoro-docs

@adrian-miasik adrian-miasik added 2. Priority: High High Priority PR - This needs te be prioritized over Normal, and Low priority based labels. Requirement: Verify / Q&A This tag needs to be addressed before it's merged. labels Feb 16, 2022
@adrian-miasik adrian-miasik self-assigned this Feb 16, 2022
@adrian-miasik adrian-miasik added this to the 1.10.0 milestone Feb 16, 2022
@adrian-miasik adrian-miasik mentioned this pull request Feb 16, 2022
Closed
@adrian-miasik
Create scalable blur config asset
cdeec7b
@adrian-miasik
Create confirmation dialog blur material
8df959d
@adrian-miasik
Implement translucent blur overlay to confirmation dialog
bb078ef
@adrian-miasik
Improve confirmation dialog visuals and UI anchoring
9e08c10
@adrian-miasik
Remove excess assets (demos) from translucent image
6d7201a
@adrian-miasik
Create ConfirmationDialogManager and move relevant PomodoroTimer logi…
6b8bac3 
…c there
@adrian-miasik
Remove translucent demo cs solution
8617f69
@adrian-miasik
Commit translucent image .csproj files
2ba2617
@adrian-miasik
Re-structure pomodoro timer hierarchy (Intent is to put all objects u…
9d426f8 
…nder our root script and lean off of scene UnityEvents)

This might have performance implications but we can fix those once we come across them. The other intent with this change is to remove the UnityEvent scene references. It's better to hook them up via code since it's more easily found, instead of hiding method calls in scene assets.
@adrian-miasik
Fix pomodoro entry animation
0f6725f
@adrian-miasik
Fix play button (No use of scene UnityEvents but instead subscribed v…
556e67a 
…ia code)
@adrian-miasik
Fix restart button
a8db772
@adrian-miasik
Fix skip button
de1792a
@adrian-miasik
Fix timer mode switch boolean button
176ac13
@adrian-miasik
Fix tomato trash button
ab8e1df
@adrian-miasik
Fix trash tomatoes reference
63ae05c
@adrian-miasik
Fix theme slider visuals
3119271
@adrian-miasik
Fix theme slider
d1ff255
@adrian-miasik
Show sidebar by default on main scene (temporarily)
cdfe06e
@adrian-miasik
Fix sidebar rows
57e7723
@adrian-miasik
Fix theme slider to respect dark mode settings property
1f4766f
@adrian-miasik
Fix set digit format dropdown settings option
afccac6
@adrian-miasik
Autogen csharp change
da4895c
@adrian-miasik
Fix double theme registration on tomato counter settings change
d3a0a45
@adrian-miasik
Remove redundant parenthesis
2ae5140
@adrian-miasik
Stub in TODO into PomodoroTimer regarding double registering certain …
8e4852e 
…theme elements
@adrian-miasik
Create blur overlay script and basic implementation
04e8f91 
Still some work to do on toggling the overlay when multiple components talk to the blur overlay
@adrian-miasik
Prevent clicking of blurred elements
d8f0a7c
@adrian-miasik
Fix credit bubble UI layer order
3093758
@adrian-miasik
Fix background digit/selection clearing
2b73bd7
@adrian-miasik
Fix sidebar overlay close
d00f639
@adrian-miasik
Rename about page properties and methods
13d8227
@adrian-miasik
Stub in credits bubble TODO in PomodoroTimer
8eae9df
@adrian-miasik
Create ImageHoverColorChange class and implement into confirmation di…
60ac233 
…alog
@adrian-miasik
Move PomodoroTimer outside of component namespace
1e315d4
@adrian-miasik adrian-miasik added Status: Completed / Ready to Merge This PR has passed all our requirements and is ready to be merged in. and removed Requirement: Verify / Q&A This tag needs to be addressed before it's merged. labels Feb 17, 2022
@adrian-miasik adrian-miasik marked this pull request as ready for review February 17, 2022 19:47
@adrian-miasik adrian-miasik merged commit ec74d98 into develop Feb 17, 2022
@adrian-miasik adrian-miasik deleted the feature/blur-asset-implementation branch February 17, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrian-miasik adrian-miasik

Labels
2. Priority: High High Priority PR - This needs te be prioritized over Normal, and Low priority based labels. Status: Completed / Ready to Merge This PR has passed all our requirements and is ready to be merged in.
Projects
No open projects
@adrian-miasik's - Open Source Workload
Status: Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adrian-miasik