Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate scope inference #101

Merged
merged 5 commits into from
Aug 8, 2022
Merged

Incorporate scope inference #101

merged 5 commits into from
Aug 8, 2022

Conversation

adriangb
Copy link
Owner

@adriangb adriangb commented Aug 8, 2022

Taking advantage of adriangb/di@b0cd073 to make things a bit less verbose and error prone.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #101 (98f5b19) into main (3e34996) will decrease coverage by 0.20%.
The diff coverage is 63.63%.

❗ Current head 98f5b19 differs from pull request most recent head b04e42e. Consider uploading reports for the commit b04e42e to get more accurate results

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   98.53%   98.32%   -0.21%     
==========================================
  Files         126      127       +1     
  Lines        4220     4230      +10     
  Branches      595      598       +3     
==========================================
+ Hits         4158     4159       +1     
- Misses         30       37       +7     
- Partials       32       34       +2     
Impacted Files Coverage Δ
xpresso/applications.py 96.03% <ø> (ø)
xpresso/routing/operation.py 100.00% <ø> (ø)
xpresso/routing/websockets.py 92.59% <ø> (ø)
xpresso/_utils/scope_resolver.py 60.00% <60.00%> (ø)
xpresso/dependencies/_dependencies.py 100.00% <100.00%> (ø)
tests/test_docs/advanced/test_websockets.py 92.00% <0.00%> (-8.00%) ⬇️
tests/test_request_bodies/test_file.py 98.40% <0.00%> (-1.60%) ⬇️
tests/test_request_bodies/test_multipart.py 99.29% <0.00%> (-0.71%) ⬇️

@adriangb adriangb enabled auto-merge (squash) August 8, 2022 18:46
@adriangb adriangb merged commit 688671d into main Aug 8, 2022
@adriangb adriangb deleted the incorporate-scope-inference branch August 8, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants