Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't run sync dependencies in threads by default #109

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Conversation

adriangb
Copy link
Owner

@adriangb adriangb commented Oct 4, 2022

Not modifying the code that users give us by default seems like the most sensible thing to do.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Merging #109 (7dbb3cb) into main (a292301) will decrease coverage by 0.09%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   98.44%   98.34%   -0.10%     
==========================================
  Files         127      123       -4     
  Lines        4231     4226       -5     
  Branches      598      417     -181     
==========================================
- Hits         4165     4156       -9     
- Misses         32       35       +3     
- Partials       34       35       +1     
Impacted Files Coverage Δ
xpresso/_utils/overrides.py 100.00% <ø> (ø)
xpresso/routing/operation.py 100.00% <ø> (ø)
xpresso/dependencies/_dependencies.py 86.20% <50.00%> (-13.80%) ⬇️
xpresso/_utils/endpoint_dependant.py 100.00% <100.00%> (ø)
xpresso/exceptions.py
xpresso/typing.py
xpresso/dependencies/__init__.py
tests/__init__.py

@adriangb adriangb merged commit ae15865 into main Oct 5, 2022
@adriangb adriangb deleted the fix-sync-to-thread branch October 5, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants