Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Display non English characters without conversion to unicode code #95

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

MaxShoshin
Copy link

Avoid conversion non english characters to unicode codes:

Current result example:

{
      "message": "\u041F\u0430\u043F\u043A\u0430",
}

After this fix:

{
      "message": "Папка",
}

@adrianiftode
Copy link
Owner

Thanks for opening this PR. Could you also add a test that covers this?

@MaxShoshin
Copy link
Author

MaxShoshin commented Sep 10, 2022

Many thanks!
I'll do it

@MaxShoshin MaxShoshin changed the title Display non English characters without conversion to unicode code [WIP] Display non English characters without conversion to unicode code Sep 10, 2022
@adrianiftode
Copy link
Owner

I'm merging this because the failing tests are for a different reason, thank you again for your contribution

@adrianiftode adrianiftode merged commit a49a9ae into adrianiftode:master Sep 11, 2022
@MaxShoshin
Copy link
Author

The failing tests are related with indirect reference to System.Text.Encoding.Web (System.Text.Json references 5.0.1), but in .Net Core 3.1 (or earlier), ref assemblies contains this version of assembly with version 4.x.x...

So to fix it - it will be nice to add direct dependency to System.Text.Encoding.Web version 5.0.1.

But i don't think it is a good solution. I've tried to somehow workaround it, but no success on it.

@adrianiftode
Copy link
Owner

@MaxShoshin I pushed your change into the 1.2.2 release. I bumped the version of the System.Text.Json package to 5.0.2 to fix the failing tests. It looks like System.Text.Encoding.Web.5.0.1 had some security issues anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants