Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Consumption Unit to Watt-hour to Match In-Car Unit #717

Merged
merged 7 commits into from
May 19, 2020

Conversation

mattw01
Copy link
Contributor

@mattw01 mattw01 commented May 14, 2020

Updated Consumption unit in Drives and Efficiency dashboards to Watt-hour (Wh) per #675

Modify Consumption column to Watt-hour (Wh) unit from Kilowatt-hour (kWh) and set decimal to 0 to match in-car unit.
Modify Consumption (net) / (gross) Singlestat values and Consumption/100mi table column to Watt-hour (Wh) unit from Kilowatt-hour (kWh) and set decimal to 0 to match in-car unit.
Copy link
Collaborator

@adriankumpf adriankumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Using Wh/km everywhere definitely makes sense. Only a few minor changes need to be made before this can be merged :)

grafana/dashboards/drives.json Outdated Show resolved Hide resolved
grafana/dashboards/efficiency.json Show resolved Hide resolved
Remerge master drives.json to include lastest commits
Include length unit in consumption value.
Wh/km or Wh/mi
Include length unit in consumption value.
Wh/km or Wh/mi
Modify Consumption column to Watt-hour per length unit from Kilowatt-hour (kWh) and set decimal to 0 to match in-car unit.
@mattw01
Copy link
Contributor Author

mattw01 commented May 14, 2020

Modified it a bit more to include the length unit.
Grafana supports custom units since version 6.6. I updated the units to include the current $length_unit. So it should display either Wh/km or Wh/mi to be a bit more specific.

Fix Consumption panel postfix value
Copy link
Collaborator

@adriankumpf adriankumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks!

"mappingType": 1,
"pattern": "consumption_km",
"thresholds": [],
"type": "number",
"unit": "kwatth"
"unit": "Wh/km"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@adriankumpf adriankumpf merged commit 2652c0b into teslamate-org:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants