Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with musl libc #31

Merged
merged 1 commit into from Nov 24, 2015
Merged

Build with musl libc #31

merged 1 commit into from Nov 24, 2015

Conversation

doughdemon
Copy link
Contributor

Build fix for musl libc (http://musl-libc.org).

@doughdemon
Don't use stdin as an lvalue
fe2d833 
freopen will always returns its last argument or 0. Therefore there
is no need of the unportable pratice of assigning stdin a value.

This fixes compilation with musl libc
@doughdemon
Copy link
Contributor Author

The Changelog says about changes from 1.50 to 1.51:

  • Using tty for interactive input instead of regular stdin. This is to
    allow feeding filenames via stdin in future versions of fdupes without
    breaking interactive deletion feature.

It makes no difference whether stdin is on the left of freopen or not,
unless an error occurs, in which case the program will crash horribly.

adrianlopezroche added a commit that referenced this pull request Nov 24, 2015
@adrianlopezroche
Merge pull request #31 from doughdemon/master
95f7b0d 
Build with musl libc.
@adrianlopezroche adrianlopezroche merged commit 95f7b0d into adrianlopezroche:master Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doughdemon @adrianlopezroche