Add phpcs

adriansuter · Jan 3, 2020 · 6b9658e · 6b9658e
1 parent 87d6b04
commit 6b9658e
Show file tree

Hide file tree

Showing 36 changed files with 133 additions and 70 deletions.
diff --git a/composer.json b/composer.json
@@ -26,7 +26,8 @@
   "autoload-dev": {
     "psr-4": {
       "My\\Integration\\": "tests/integration/src",
-      "AdrianSuter\\Autoload\\Override\\": "tests/integration/src-override"
+      "AdrianSuter\\Autoload\\Override\\": "tests/integration/src-override",
+      "AdrianSuter\\Autoload\\Override\\Tests\\": "tests"
     },
     "classmap": [
       "tests/integration/src/TestClassMapOverride"
@@ -37,12 +38,15 @@
     "nikic/php-parser": "^4.3"
   },
   "require-dev": {
-    "phpunit/phpunit": "^7.0"
+    "phpunit/phpunit": "^7.0",
+    "squizlabs/php_codesniffer": "^3.5"
   },
   "scripts": {
     "test": [
-      "@phpunit"
+      "@phpunit",
+      "@phpcs"
     ],
-    "phpunit": "phpunit"
+    "phpunit": "phpunit",
+    "phpcs": "phpcs"
   }
 }
diff --git a/phpcs.xml b/phpcs.xml
@@ -0,0 +1,17 @@
+<?xml version="1.0"?>
+<ruleset name="PHP Autoload Override coding standard">
+    <description>PHP Autoload Override coding standard</description>
+
+    <!-- display progress -->
+    <arg value="p"/>
+    <!-- use colors in output -->
+    <arg name="colors"/>
+
+    <!-- inherit rules from: -->
+    <rule ref="PSR12"/>
+    <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
+
+    <!-- Paths to check -->
+    <file>src</file>
+    <file>tests</file>
+</ruleset>
diff --git a/src/AutoloadCollection.php b/src/AutoloadCollection.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *

diff --git a/src/ClosureHandler.php b/src/ClosureHandler.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *

diff --git a/src/CodeConverter.php b/src/CodeConverter.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *
@@ -75,10 +76,10 @@ public function __construct(
         ?NodeFinder $nodeFinder = null
     ) {
         $this->lexer = $lexer ?? new Emulative(
-                [
+            [
                     'usedAttributes' => ['comments', 'startLine', 'endLine', 'startTokenPos', 'endTokenPos'],
                 ]
-            );
+        );
 
         $this->parser = $parser ?? new Php7($this->lexer);
 

diff --git a/src/FileStreamWrapper.php b/src/FileStreamWrapper.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *
@@ -42,6 +43,7 @@
 use function touch;
 use function unlink;
 
+// phpcs:disable PSR1.Methods.CamelCapsMethodName
 class FileStreamWrapper
 {
     /**

diff --git a/src/Override.php b/src/Override.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *

diff --git a/tests/AbstractIntegrationTest.php b/tests/AbstractIntegrationTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *
@@ -7,6 +8,8 @@
 
 declare(strict_types=1);
 
+namespace AdrianSuter\Autoload\Override\Tests;
+
 use AdrianSuter\Autoload\Override\Override;
 use PHPUnit\Framework\TestCase;
 
@@ -24,7 +27,6 @@ public static function setUpBeforeClass()
     protected function setUp()
     {
         parent::setUp();
-
         if (!$this->overrideApplied) {
             $this->overrideApplied = true;
             Override::apply(self::$classLoader, $this->getOverrideDeclarations());

diff --git a/tests/AutoloadCollectionTest.php b/tests/AutoloadCollectionTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *
@@ -7,6 +8,8 @@
 
 declare(strict_types=1);
 
+namespace AdrianSuter\Autoload\Override\Tests;
+
 use AdrianSuter\Autoload\Override\AutoloadCollection;
 use PHPUnit\Framework\TestCase;
 

diff --git a/tests/ClosureHandlerTest.php b/tests/ClosureHandlerTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *
@@ -7,8 +8,11 @@
 
 declare(strict_types=1);
 
+namespace AdrianSuter\Autoload\Override\Tests;
+
 use AdrianSuter\Autoload\Override\ClosureHandler;
 use PHPUnit\Framework\TestCase;
+use RuntimeException;
 
 final class ClosureHandlerTest extends TestCase
 {

diff --git a/tests/CodeConverterTest.php b/tests/CodeConverterTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *
@@ -7,6 +8,8 @@
 
 declare(strict_types=1);
 
+namespace AdrianSuter\Autoload\Override\Tests;
+
 use AdrianSuter\Autoload\Override\CodeConverter;
 use PHPUnit\Framework\TestCase;
 
@@ -15,7 +18,6 @@ class CodeConverterTest extends TestCase
     public function testA()
     {
         $converter = new CodeConverter();
-
         $this->assertEquals(
             '<?php echo \foo\rand(0, 9);',
             $converter->convert('<?php echo \rand(0, 9);', ['\rand' => 'foo\rand'])

diff --git a/tests/FileStreamWrapperTest.php b/tests/FileStreamWrapperTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *
@@ -7,8 +8,12 @@
 
 declare(strict_types=1);
 
+namespace AdrianSuter\Autoload\Override\Tests;
+
 use AdrianSuter\Autoload\Override\FileStreamWrapper;
 use PHPUnit\Framework\TestCase;
+use ReflectionProperty;
+use RuntimeException;
 
 final class FileStreamWrapperTest extends TestCase
 {

diff --git a/tests/IntegrationClassMapTest.php b/tests/IntegrationClassMapTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * PHP Autoload Override (https://github.com/adriansuter/php-autoload-override)
  *
@@ -7,18 +8,22 @@
 
 declare(strict_types=1);
 
+namespace AdrianSuter\Autoload\Override\Tests;
+
 class IntegrationClassMapTest extends AbstractIntegrationTest
 {
     protected function getOverrideDeclarations(): array
     {
         return [
             \My\Integration\TestClassMapOverride\Calculator::class => [
                 'cos' => function (float $arg): float {
+
                     return \sin($arg);
                 },
             ],
             'My\\Integration\\TestClassMapOverride\\' => [
                 'cos' => function (float $arg): float {
+
                     return $arg * 2;
                 },
             ]
@@ -28,24 +33,21 @@ protected function getOverrideDeclarations(): array
     public function testCalculator()
     {
         $calculator = new \My\Integration\TestClassMapOverride\Calculator();
-
-        // Calls \cos() > Overridden by FQCN-declaration.
+// Calls \cos() > Overridden by FQCN-declaration.
         $this->assertEquals(\sin(\pi() / 2), $calculator->cos(\pi() / 2));
     }
 
     public function testGeometry()
     {
         $geometry = new \My\Integration\TestClassMapOverride\SubNamespace\Geometry();
-
-        // Calls \cos() > Overridden by FQNS-declaration.
+// Calls \cos() > Overridden by FQNS-declaration.
         $this->assertEquals(1, $geometry->cos(0.5));
     }
 
     public function testOtherCalculator()
     {
         $otherCalculator = new \My\Integration\TestClassMapOverride\OtherCalculator();
-
-        // Calls \cos() > Overridden by FQNS-declaration.
+// Calls \cos() > Overridden by FQNS-declaration.
         $this->assertEquals(2, $otherCalculator->cos(1));
     }
 }