Handle elements in non-children props in shallow render

[stevoland]

Currently React elements in props other than children aren't processed so snapshots will end up with toString()ed component types.

This is a breaking change for those with existing snapshots of elements containing elements in non-children props.

[codecov-io]

Current coverage is 100% (diff: 100%)

Merging #24 into master will not change coverage

@@           master   #24   diff @@
===================================
  Files           3     3          
  Lines          38    46     +8   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
+ Hits           38    46     +8   
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update c029ba9...c542b80

[adriantoine]

Hi @stevoland, thanks for your contribution! Looks pretty neat, I can't review it properly right now, I'll have a look later this afternoon, sorry!

[adriantoine]

I would prefer that to use Object.entries and reduce:

return Object.entries(node).reduce((obj, [key, val]) => {
    obj[key] = nodeToJson(val);
    return obj;
}, {});

What do you think?

[stevoland]

cool, didn't know about object.entries. will change

[stevoland]

fixed, thanks

[adriantoine]

Ah sorry, tests are failing because Object.entries is not available in Node v4. Can you use object.entries?

import entries from 'object.entries';

// ...

return entries(node).reduce(...

[stevoland]

done

[adriantoine]

Nice

[adriantoine]

Merged 🎉 Really nice @stevoland, thanks a lot for your contribution 👍 It will go in the next published release very soon.

[adriantoine]

The change is published in v1.2.0 🎉

[stevoland]

I'm afraid you might want consider reverting this. I've just noticed that when testing react-native, a previous snapshot of:

<AnimatedComponent
            opacity={0}
/>

is now

<AnimatedComponent
            opacity={
              Object {
                "_animation": Object {
                  "__active": true,
                  "__isInteraction": true,
                  "__onEnd": [Function],
                 ...
/>

I'll try to fix this afternoon. Sorry :/

[adriantoine]

Ah crap, it might be a good thing to have React Native unit tests but I'm not sure how to do that as I'm not familiar with React Native.

[stevoland]

Should have a fix in an hour. I think using lodash isPlainObject instead of simple typeof check for object will fix

[stevoland]

This should fix it: #25

Sorry again!