Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unified_dyes integration #14

Merged
merged 1 commit into from Nov 9, 2022
Merged

fix unified_dyes integration #14

merged 1 commit into from Nov 9, 2022

Conversation

fluxionary
Copy link

currently, if you craft milky glass, place it, and break it, it will not stack w/ any that haven't been placed.

this fixes that by ensuring that the crafted variety has the same metadata as the default color.

this does not fix any milky glass that has already been crafted; fixing that would require a way to override the contents of every inventory, which is beyond the scope of this issue.

@adrido
Copy link
Owner

adrido commented Nov 9, 2022

👍
For the next time it woud be easier, if there where 2 commits, one to fix the whitespaces, and one for the actual bugfix.
Thank you for your work.

@adrido adrido merged commit c46c624 into adrido:master Nov 9, 2022
@fluxionary
Copy link
Author

one to fix the whitespaces

sorry about that, i don't think i even noticed that my IDE got friskier than it should have. it's only supposed to format lines i touch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants