proposal: a new flow to dispose things #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrielcafe
reviewed
Oct 18, 2021
| @@ -1,14 +1,19 @@ | |||
| package cafe.adriel.voyager.navigator | |||
|
|
|||
| import android.app.Activity | |||
There was a problem hiding this comment.
Since we plan to support KMM soon, depending on Activity will make the task harder. We should find another way to fix this. Perhaps implementing inside AndroidScreen?
There was a problem hiding this comment.
The main reason to reference Activity here are the two functions created to get current activity and to avoid break working samples. The two functions must be moved our from Navigator file. I'll do that.
|
It doesn't work with nested navigation. Possible solution: before finish the Activity you should verify if device-2021-10-18-100715.mp4 |
programadorthi
force-pushed
the
fix/dispose-on-back-press
branch
2 times, most recently
from
ff00b41
to
da53436
Compare
programadorthi
changed the title
programadorthi
force-pushed
the
fix/dispose-on-back-press
branch
from
c2c1f45
to
8422f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is try to fix when we are in the first screen and hit back press closing the activity. But the first screen on navigator was not calling disposing function after back press.
So now it will call ScreenModel onDispose or ViewModel onCleared when hit onBackPress in the first screen on Navigator.
This PR is a try to fix #20 and #23 too