Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossfade transition #286

Merged
merged 2 commits into from Jan 19, 2024
Merged

Add crossfade transition #286

merged 2 commits into from Jan 19, 2024

Conversation

Revxrsal
Copy link
Contributor

This PR adds a basic crossfade transition for navigation, as I felt it's missing.

Copy link
Collaborator

@DevNatan DevNatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary compatibility check failed please run gradle apidump to regenerate .api with your code. Also, can you provide a GIF using this transition on one of our samples, for us to include in the docs

@Revxrsal
Copy link
Contributor Author

I made the function public. I've tried running gradle apidump, but it gave me an error about local.properties missing. I admittedly feel it's unnecessary to go through the whole setup procedure and install what's probably worth 1GB+ dependencies for all the platforms that Voyager supports, just to add a simple function 😅

Here's a GIF:
Crossfade

@Revxrsal
Copy link
Contributor Author

Hey @DevNatan o/ I know you're busy, but could you please let me know if anything's left here? I use voyager in so many projects and this would save me lots of time 🙆‍♂️

@DevNatan DevNatan merged commit 2f7419d into adrielcafe:main Jan 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants