Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM support #289

Merged
merged 6 commits into from Feb 23, 2024
Merged

WASM support #289

merged 6 commits into from Feb 23, 2024

Conversation

DevSrSouza
Copy link
Collaborator

@DevSrSouza DevSrSouza commented Dec 27, 2023

This PR adds the support for Kotlin WASM and update the Compose to 1.6.0-rc02.

Testing WASM support:
./gradlew :samples:multiplatform:wasmJsBrowserDevelopmentRun

@likeich
Copy link

likeich commented Dec 28, 2023

Does this need any testing? I would love to help in any way to get this implemented sooner.

@DevSrSouza DevSrSouza mentioned this pull request Dec 28, 2023
@DevSrSouza
Copy link
Collaborator Author

Everything is working pretty well so far, State restauration, etc. Just need to fix the build and migrate the Kotlin DSL to the new structure.

Feel free to checkout to the branch and test by publishing locally and using in your project!

@joreilly
Copy link

joreilly commented Dec 28, 2023

You might have seen it already but just fyi re. 1.8.0-RC2 of Kotlinx Coroutines....I think it should mean you won't have to include atomicfu as dependency (https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.8.0-RC2)

@DevSrSouza
Copy link
Collaborator Author

Thanks @joreilly , I will update the Coroutines here and see if is not required anymore.
But the plugin maybe should be required for be more performant, their is a branch of Compose Multiplatform Core applying AtomicFu Gradle Plugin. I'm following the same approach to avoid boxing types when is possible.

@luludevmuniz
Copy link

Hey there, I would like to test it but I don't know how to publish it locally.
Is there a guide for it, or any plans to release it as a alpha?

Comment on lines +6 to +7
<script type="application/javascript" src="skiko.js"></script>
<script type="application/javascript" src="composeApp.js"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put these scripts before </body> tag? Loading scripts inside head tag is not recommended.

@programadorthi
Copy link
Collaborator

@luludevmuniz try ./gradlew -Pversion=1.0.0 publishToMavenLocal

@joreilly
Copy link

When is it hoped to merge this and include in a release?

@Syer10
Copy link
Contributor

Syer10 commented Jan 27, 2024

Probably after Compose 1.6 is released

@DevSrSouza DevSrSouza merged commit 22cbd62 into main Feb 23, 2024
1 check passed
@DevSrSouza DevSrSouza deleted the kotlin-wasm branch February 23, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Compose Multiplatform for Web (Wasm) Support for kotlin/wasm
6 participants