service autocompletion not working on container shortcuts

[jovobe]

If you use a container-shortcut for the get-method like the "Symfony\Bundle\FrameworkBundle\Controller\Controller" but not call the get-method directly on the container-object ($this->container->get($id)) e.g. with a getter: $this->getContainer()->get($id)

the autocompletion for the services is not working. The $this->getContainer() getter has a correct annotation:

[adrienbrault]

The plugin initially had some support for this. However, because the implementation felt a bit like a hack and to improve performance, it was removed.

[adrienbrault]

Would you like to be able to have an per project setting to add your CustomBaseController:get method signature ?

[Haehnchen]

we only need to resolve the $id parameter. i did some research on that before, that looks working, but needs some more improvements

PhpPsiElement value = ((AssignmentExpression)parent).getValue();

[jovobe]

I think a method signature per project would fix my problem for now. However, I think that it is not a clean solution. The right way would be to resolve the $id paramenter depending on the annotation of the $this->getContainer() method.

[cerritus]

Autocomplete for getRepository shotrcut also doesn't work

public function getRep($name)
{
    return $this->get('doctrine')->getRepository($name);
}

[Haehnchen]

same issue, if we resolve the first one we will also get the second :)
by the way here is also a reflink: http://devnet.jetbrains.com/message/5486464

[heorshe]

+1 this would indeed be a good feature

[Haehnchen]

can now be configured or activate on docblocks: http://symfony2-plugin.espend.de/extension/method_parameter.html

[heorshe]

autocomplete for parameters works, but autocomplete for return value not work :(

/**
 * @param string $serviceName #Service
 */
protected function get($serviceName)
{
    return $this->container->get($serviceName);
}

/**
 * @param string $entityName #Entity
 */
protected function getRep($entityName)
{
    return $this->container->get('doctrine')->getRepository($entityName);
}

$this->container->get('router')-> // work
$this->get('router')-> // not work
$this->container->get('doctrine')->getRepository('App:User')-> // work
$this->getRep('App:User')-> // not work

[Haehnchen]

iam also search for a solution many times on that, but currently its not possible because of api limits and needs some hacking code...

[Haehnchen]

close... all core suitable core method support it now

[heorshe]

autocomplete for return value still not working

$this->container->get('router')-> // work
$this->get('router')-> // not work

maybe it is necessary to add ContainerAware in SymfonyPhpReferenceContributor.CONTAINER_SIGNATURES instead of Controller?

    private static MethodMatcher.CallToSignature[] CONTAINER_SIGNATURES = new MethodMatcher.CallToSignature[] {
        new MethodMatcher.CallToSignature("\\Symfony\\Component\\DependencyInjection\\ContainerInterface", "get"),
        new MethodMatcher.CallToSignature("\\Symfony\\Component\\DependencyInjection\\ContainerAware", "get"),
    };