Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader includes and variants #144

Closed
adriengivry opened this issue Sep 29, 2020 · 2 comments
Closed

Shader includes and variants #144

adriengivry opened this issue Sep 29, 2020 · 2 comments
Labels
Feature New feature to the engine Graphics Graphical feature QoL Quality of Life : Something that can improve users productivity

Comments

@adriengivry
Copy link
Owner

Problem this feature should fix
Having to deal with only one file per shader is sometimes a problem (Code duplication).
For instance, it would be nice to share our vertex or our fragment shader between all shaders.
It would also be nice to have a shader library (BRDF, tools, noise...) available for other shaders.

Expected solution
We should implement shader include and variant systems (#define, #ifdef).

@adriengivry adriengivry added QoL Quality of Life : Something that can improve users productivity Feature New feature to the engine Graphics Graphical feature labels Sep 29, 2020
@adriengivry
Copy link
Owner Author

Maybe this is the right time to introduce our own shader syntax. We can inspire from ShaderLab, which appears to be very convenient.

@adriengivry
Copy link
Owner Author

Duplicate of #104

@adriengivry adriengivry marked this as a duplicate of #104 Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature to the engine Graphics Graphical feature QoL Quality of Life : Something that can improve users productivity
Projects
None yet
Development

No branches or pull requests

1 participant