Skip to content
This repository has been archived by the owner on Apr 14, 2018. It is now read-only.

fix git check-ref-format call #7

Merged
merged 1 commit into from Sep 18, 2013

Conversation

leinaddm
Copy link
Contributor

fix quotes in git check-ref-format call, otherwise it's useless.

What's the deal with the following construct? isn't it the same as if !system ?? If not I can put it back.

if !system("...") || $?.existatus > 0

@adrienthebo
Copy link
Owner

if ! condition and unless condition do the same thing; generally it's a question of what's most readable.

Thanks for this contribution!

adrienthebo added a commit that referenced this pull request Sep 18, 2013
@adrienthebo adrienthebo merged commit 59edddb into adrienthebo:master Sep 18, 2013
@leinaddm
Copy link
Contributor Author

I was referring to the !system || $?.exitstatus > 0 .
Both conditions check the same thing afaik.

  • Adrien Thebo notifications@github.com [09/18/2013 18:41]:

    if ! condition and unless condition do the same thing; generally it's a
    question of what's most readable.

    Thanks for this contribution!

@leinaddm leinaddm deleted the fix-check-ref-format branch September 18, 2013 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants