Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.7-3.4 #68

Merged
merged 2 commits into from Aug 9, 2020

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jul 27, 2020

@adrienverge
Copy link
Owner

I know Python 2 was recently sunset, but I don't see the need to drop support now, if it still continues to work. Is the code simplification it brings the only reason, or do you have another one?

@hugovk
Copy link
Contributor Author

hugovk commented Jul 27, 2020

Yeah, you can keep it if you like, maybe not as big benefits for this project as for others.

Here's some reasons:

  • Security:
    • Python 2.7 is no longer maintained and won't have any new security vulnerabilities fixed
    • Pillow no longer supports Python 2.7, and the last release for 2.7 doesn't have security fixes
    • PyCairo no longer supports Python 2.7
  • You can start to use new Python features without worrying about old versions
  • Use fewer CI testing resources
  • It's becoming less and less used or relevant: https://github.com/hugovk/pypi-tools/blob/master/README.md#examples

@adrienverge
Copy link
Owner

OK, you convinced me. Can you please rebase on latest master?

@hugovk
Copy link
Contributor Author

hugovk commented Aug 8, 2020

Rebased!

Copy link
Owner

@adrienverge adrienverge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adrienverge adrienverge merged commit e4120e4 into adrienverge:master Aug 9, 2020
@hugovk hugovk deleted the update-versions2 branch August 9, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants