Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll-Up of Features + Reset Button and development environment #84

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Roll-Up of Features + Reset Button and development environment #84

wants to merge 21 commits into from

Conversation

zkhcohen
Copy link

@zkhcohen zkhcohen commented Feb 8, 2022 •
edited

All features have been tested and are working.

Integrates the following features:

Adds:

  1. Reset Button - removes all images from collage in one click.
  2. Modern development workflow for Windows, using VSCode and Docker devcontainer. Also includes test images from public dataset.

Joël BOURGAULT and others added 21 commits November 10, 2017 10:26
adrienverge#38: now remembers last visited directory.
f475801 
This works by file selection using the GUI, or by file addition with a
drag&drop operation.

Signed-off-by: Joël Bourgault <joel.bourgault@gmail.com>
fixing coding rules
c7c4819 
Signed-off-by: Joël BOURGAULT <jbourgault@sii.fr>
Merge branch 'master' into feature-adrienverge#38-remember-last-visit…
4fcf328 
…ed-dir
gktgui: default input selection folder is now None
f534d50 
Also, changed signature of PreviewFileChooserDialog, to have `folder`
as a visible parameter.

Signed-off-by: Joël Bourgault <joel.bourgault@gmail.com>
gtkgui: adding remembering of output folder selection
681de61 
Signed-off-by: Joël Bourgault <joel.bourgault@gmail.com>
Create config class, to handle session and parameters to filesystem.
e4324d2 
This is linked to issue adrienverge#38: remember last visited directory.

Access to configuration data can be performed by attribute or as dict
entries.

File is in YAML format, and is written automatically at exit.

I choose to make interface with other Gtk classes 'simpler', i.e. at a
lower level: these do not access Options instance directly, but directly
to parameters or to `parent` instance.

Signed-off-by: Joël Bourgault <joel.bourgault@gmail.com>
Added commandline tool.
18713dc
reformatted file to comply with flake's coding conventions
d0affb1
Merge branch 'master' into master
6754267
@zkhcohen
Merge branch 'create-session-and-config-file' of https://github.com/o…
3b709e8 
…job/PhotoCollage
@zkhcohen
merging
59beb55
@zkhcohen
Merge branch 'create-session-and-config-file' of https://github.com/o…
19b6029 
…job/PhotoCollage
@zkhcohen
Merge branch 'ojob-feature-adrienverge#38-remember-last-visited-dir'
3f7dbc8
@zkhcohen
Merge pull request #3 from wagnerb4/master
96b6538 
Added Command Line Interface
@zkhcohen
Removed backup files.
afbcca1
@zkhcohen
Began building dev container for testing.
89f5633
@zkhcohen
LF
b8ebe58
@zkhcohen
Added containerized dev environment. Added test image set.
4472712
@zkhcohen
Merge pull request #4 from zkhcohen/reset-button
cb5072d 
Added dev container / environment and test image set
@zkhcohen
Added reset button. Updated task to start photocollage after build.
8a4f474
@zkhcohen
Merge pull request #5 from zkhcohen/reset-button
717391a 
Reset button added
IHappyDayI added a commit to IHappyDayI/PhotoCollage that referenced this pull request Feb 23, 2023
@IHappyDayI
Merge pull request #1 from zkhcohen/master
f438f33 
 Roll-Up of Features + Reset Button and development environment adrienverge#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zkhcohen