test_cli.py: test_find_files_recursively() breaks when build directory sorts before /etc

[siriobalmelli]

see

yamllint/tests/test_cli.py

Lines 152 to 158 in 0fff4e2

	items = [os.path.join(self.wd, 'sub'),
	os.path.join(self.wd, '/etc/another/file')]
	self.assertEqual(
	sorted(cli.find_files_recursively(items, conf)),
	[os.path.join(self.wd, '/etc/another/file'),
	os.path.join(self.wd, 'sub/directory.yaml/empty.yml'),
	os.path.join(self.wd, 'sub/ok.yaml')],

The semantics of os.path.join are such that:

import os
pwd = '/an/inconvenient/dir'
absolute = os.path.join(pwd, '/etc/another/file')
relative = os.path.join(pwd, 'sub/directory.yaml/empty.yml')
absolute < relative  # False
pwd = '/home/user'
relative = os.path.join(pwd, 'sub/directory.yaml/empty.yml')
absolute < relative  # True

Recommend turning /etc/another/file into a relative path.

[siriobalmelli]

Thank you to @dotlambda for linking to the proper lines in test_cli.py