quoted-strings: Fix only-when-needed on corner cases #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienverge
force-pushed
the
fix/quoted-strings-detect-needed-correctly
branch
from
7d42414
to
932952c
Compare
Change implementation of `required: only-when-needed`, because maintaining a list of `START_TOKENS` and just looking at the first character of string values has proven to be partially broken. Cf. discussion at #246 (comment). Fixes #242 and #244.
adrienverge
force-pushed
the
fix/quoted-strings-detect-needed-correctly
branch
from
932952c
to
28652b4
Compare
This was referenced Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change implementation of
required: only-when-needed, becausemaintaining a list of
START_TOKENSand just looking at the firstcharacter of string values has proven to be partially broken.
Cf. discussion at #246 (comment).
Fixes #242 and #244.
@ruipinge what do you think? Do you see problems / unhandled cases?