Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Simplify PhaseSpacePosition and Orbit classes #83

Merged
merged 99 commits into from Jul 10, 2017

Conversation

adrn
Copy link
Owner

@adrn adrn commented Apr 18, 2017

This makes use of the representation differential classes in astropy/astropy#5871 to clean up a lot of the code. A natural byproduct of this is that CartesianPhaseSpacePosition and CartesianOrbit are no longer needed, since there is now a unified interface to any representations and their respective differentials.

TODO:

  • support <3D positions so nonlinear integrations work
  • remove the velocity_coord_transforms.py and use the Differential classes instead
  • figure out how to handle velocity frame transforms with the Differential classes
  • update documentation and docstrings
  • clean up all documentation that mentions Orbit or PhaseSpacePosition, check repr's (especially the orbits-in-detail.rst file
  • make sure all mention of Cartesian* is gone
  • make sure all code and doc tests run and don't use the old Cartesian* classes

API-breaking changes:

  • Velocity frame transforms now return Differential classes
  • Velocity coord transforms are gone
  • CartesianPhaseSpacePosition and CartesianOrbit are deprecated

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 82.214% when pulling a52c76b on dynamics/simplify-orbit-psp into 2c65d9e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.0%) to 87.123% when pulling 9360f3a on dynamics/simplify-orbit-psp into 2c65d9e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.0%) to 87.118% when pulling 7a9cc60 on dynamics/simplify-orbit-psp into 2c65d9e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.008%) to 87.157% when pulling 220ffb9 on dynamics/simplify-orbit-psp into 2c65d9e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.008%) to 87.157% when pulling a0d2e7e on dynamics/simplify-orbit-psp into 2c65d9e on master.

@adrn adrn force-pushed the dynamics/simplify-orbit-psp branch from 220ffb9 to 83c65d6 Compare May 9, 2017 07:56
@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 87.158% when pulling 83c65d6 on dynamics/simplify-orbit-psp into cc2bdeb on master.

@adrn
Copy link
Owner Author

adrn commented Jul 4, 2017

TODO:

  • Fix to_coord_frame and tests.
  • Why is the analytic Isochrone action angle transformation failing now?
  • G changed in astropy.constants - leading to a lot of test failures?
  • Anywhere we accept v_circ and v_lsr, should just take galactocentric frame

@adrn
Copy link
Owner Author

adrn commented Jul 6, 2017

  • PhaseSpacePosition object should gain attributes of the components of the representation/differential(s). Maybe need to define my own mappings ('v_x' = 'd_x', 'v_xyz' = 'd_xyz', etc.)

@adrn
Copy link
Owner Author

adrn commented Jul 7, 2017

  • Still needs a bunch of tests for the new component name mappings
  • Update documentation to point coordinate page to astropy.coordinates new features
  • Audit docs for d_x or mistakes about not including cos(lat) term in proper motions
  • PhaseSpacePosition should take a representation w/ differential attached

@adrn
Copy link
Owner Author

adrn commented Jul 10, 2017

  • Finish the example on integrating orbits in Barred galaxy-like potential (plot corotation, etc.) and add example of CRTBP (or make issue to do this)
  • Support differentials in ND... representation/differential class (and add tests doofus)

@adrn adrn force-pushed the dynamics/simplify-orbit-psp branch from 9386a1c to 3331b4f Compare July 10, 2017 03:03
@adrn adrn merged commit 6aef7de into master Jul 10, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 576c5ba on dynamics/simplify-orbit-psp into ** on master**.

@adrn adrn deleted the dynamics/simplify-orbit-psp branch October 17, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants