-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Simplify PhaseSpacePosition and Orbit classes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrn
force-pushed
the
dynamics/simplify-orbit-psp
branch
from
May 9, 2017 07:56
220ffb9
to
83c65d6
Compare
TODO:
|
|
|
|
…to try out using these for phasespacepositions
… attributes with different names
adrn
force-pushed
the
dynamics/simplify-orbit-psp
branch
from
July 10, 2017 03:03
9386a1c
to
3331b4f
Compare
Changes Unknown when pulling 576c5ba on dynamics/simplify-orbit-psp into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the representation differential classes in astropy/astropy#5871 to clean up a lot of the code. A natural byproduct of this is that
CartesianPhaseSpacePosition
andCartesianOrbit
are no longer needed, since there is now a unified interface to any representations and their respective differentials.TODO:
velocity_coord_transforms.py
and use theDifferential
classes insteadDifferential
classesOrbit
orPhaseSpacePosition
, check repr's (especially theorbits-in-detail.rst
fileCartesian*
is goneCartesian*
classesAPI-breaking changes:
Differential
classesCartesianPhaseSpacePosition
andCartesianOrbit
are deprecated