Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "fast" option to pericenter/apocenter and support multiple orbits #95

Closed
adrn opened this issue Jul 15, 2017 · 5 comments
Closed

Add "fast" option to pericenter/apocenter and support multiple orbits #95

adrn opened this issue Jul 15, 2017 · 5 comments

Comments

@adrn
Copy link
Owner

adrn commented Jul 15, 2017

Right now, .pericenter() and .apocenter() are slow because they do interpolation to figure out a precise value. There should be a fast=True option that skips the interpolation.

We also need to support these methods for multiple orbits in the same object.

@pkaf
Copy link

pkaf commented Dec 29, 2017

Is looping over the tracers the current preferred way to calculate .apocenter() etc? Just making sure before burning cpus. :)

@adrn
Copy link
Owner Author

adrn commented Dec 29, 2017

Yes, but knowing that someone else is feeling that pain will motivate me to actually fix this :)

@pkaf
Copy link

pkaf commented Dec 30, 2017

I will then add that the pain of not having this feature is ever increasing and will be more so post DR2. Also, it will be useful to have method zmax (maximum vertical height ).

@adrn
Copy link
Owner Author

adrn commented Apr 23, 2018

Finally addressed this in #105! Just in time for Gaia :)

@adrn
Copy link
Owner Author

adrn commented Apr 23, 2018

Once I get the tests to pass with that PR, I'll merge and release a new version.

@adrn adrn closed this as completed in #105 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants