Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snapshot outputting for mockstream #171

Merged
merged 3 commits into from May 1, 2020
Merged

Fix snapshot outputting for mockstream #171

merged 3 commits into from May 1, 2020

Conversation

adrn
Copy link
Owner

@adrn adrn commented Apr 30, 2020

Fixes #170

cc @tyavetz

@adrn adrn added the bug label Apr 30, 2020
@adrn
Copy link
Owner Author

adrn commented Apr 30, 2020 •
edited

@tyavetz It turned out that the fix was fairly simple (I think, assuming tests pass 😄). Could you try installing this branch and see if that fixes things for you?

pip install git+https://github.com/adrn/gala.git@fix-mockstream-animate

@coveralls
Copy link

coveralls commented Apr 30, 2020 •
edited

Coverage Status

Coverage remained the same at 0.0% when pulling 8f92ef8 on fix-mockstream-animate into 66ceb08 on master.

@adrn adrn merged commit 9ba47b6 into master May 1, 2020
@adrn adrn deleted the fix-mockstream-animate branch October 17, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mockstream output_every is broken
2 participants
@adrn @coveralls