Fix bug with log-determinant in marginal likelihood #87

adrn · 2019-10-20T20:47:34Z

This fixes a bug and error in The Joker to be consistent with the math in this note.

This is a Quick Fix, in that it fixes the bug, but I haven't addressed any of the API changes I would like to make.

TODO:

Update ipython notebook examples in docs to include a prior on the linear parameters.

…n implementation

coveralls · 2019-10-20T20:57:30Z

Coverage increased (+0.3%) to 88.269% when pulling 0d29d35 on fix-det-sign into 3278a79 on master.

adrn added 6 commits October 17, 2019 18:20

huh

7487a51

add required prior variance to jokerparams and implement use in pytho…

4ffd53e

…n implementation

example must have prior on linear pars

05185d4

fix the math to be consistent with the new gaussian identity document

1dce1a6

update python implementation, test cython vs python, update some tests

4a91469

fix tests with modifications of joker internals

f3aab72

adrn added 4 commits October 20, 2019 17:12

update notebook examples

23e5511

fix max_n_samples buisness

0d29d35

raise informative error if prior not specified

b6e2c8d

test failing test with no prior [ci skip]

0197a86

adrn merged commit b5cce0d into master Oct 20, 2019

Provide feedback