Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Java compatibility and migrated app module to Kotlin #16

Merged
merged 2 commits into from Oct 12, 2020
Merged

Improved Java compatibility and migrated app module to Kotlin #16

merged 2 commits into from Oct 12, 2020

Conversation

DatL4g
Copy link
Contributor

@DatL4g DatL4g commented Oct 2, 2020

Fixes #14 and an issue when calling makeDiscoverable with one parameter only

@DatL4g
Copy link
Contributor Author

DatL4g commented Oct 2, 2020

@adroitandroid
would be nice if you accept the pull request and merge for improvements for java users

@adroitandroid
Copy link
Owner

will check by Wednesday and merge, thanks

@DatL4g
Copy link
Contributor Author

DatL4g commented Oct 9, 2020

@adroitandroid
Did you check it yet?

@adroitandroid adroitandroid merged commit f5042c9 into adroitandroid:master Oct 12, 2020
@adroitandroid adroitandroid mentioned this pull request Oct 12, 2020
Closed
@DatL4g
Copy link
Contributor Author

DatL4g commented Oct 12, 2020

@adroitandroid
Thanks for merging
You should create a new release so it's easier for people to include this in their project otherwise they have to get it based on the commits from jitpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crashes app after going to background
2 participants
@DatL4g @adroitandroid