Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write additional tests for issue #1054 #22

Open
fwald opened this issue Feb 26, 2020 · 0 comments
Open

Write additional tests for issue #1054 #22

fwald opened this issue Feb 26, 2020 · 0 comments
Assignees
@fwald

Comments

@fwald
Copy link
Collaborator

fwald commented Feb 26, 2020

Write additional tests for issue#1054 as requested and suggested in the PR:

wemake-services#1185
@fwald fwald self-assigned this Feb 26, 2020
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
test: added a new test that checks that methods named get/set are all…
43c99e9 
…owed if not containing the name of a class attribute or instance attribute.

relates to #22
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
test: added a test for checking that correct use of dataclass with pr…
43f36d9 
…operty annotation is valid.

relates to #22 and wemake-services#1054
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
test: added test with class attribute and instance getters/setters th…
585bdf2 
…at should be prohibited.

relates to #22 and wemake-services#1054
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
test:
b0a5f69 
added new test cases for test_nonmatching_attribute_getter_setter, such that different
types of assignments are tested.
relates to #22 and wemake-services#1054
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
refactor:
bd92347 
refactored test_class_mixed to use stacked test parameters to make it easier to test
many combinations. Relates to #22 and wemake-services#1054
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
refactor:
49677bc 
added accessor as a new test parameter to ease the creation of
different test combinations for test_nonmatching_attribute_getter_setter and
test_instance_and_class_getter_setter.
Relates to #22 and wemake-services#1054
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
refactor:
f818784 
renamed parameters in test_instance_and_class_getter_setter and test_nonmatching_attribute_getter_setter
to ease readability.
relates to #22 and wemake-services#1054
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
test:
0871695 
added tests that checks that invalid use of class attributes
and getters and setters are prohbited.
Relates to #22, wemake-services#1054
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
test:
85977e2 
added test to ensure that class attributes with
non-matching getters and setters is allowed.
relates to #22, wemake-services#1054
fwald added a commit that referenced this issue Feb 26, 2020
@fwald
test:
f593dca 
added a test for dataclass that uses explicit getters and setters on
an instance attribute. This should be prohibited. Right now the test
is failing, which indicates that something in the implementation needs to be looked at.
Relates to #22, wemake-services#1054
fwald added a commit that referenced this issue Feb 27, 2020
@fwald
test:
e720e11 
added a test that checks that correct use of dataclass with
the propert annotation is allowed
relates to #22 and wemake-services#1054
adrwes added a commit that referenced this issue Feb 27, 2020
@adrwes @fwald @ruwaid123
Issue#22 (#24)
e606042 
* test: added a new test that checks that methods named get/set are allowed if not containing the name of a class attribute or instance attribute.
relates to #22

* fix: changed description

* test: added a test for checking that correct use of dataclass with property annotation is valid.
relates to #22 and wemake-services#1054

* test: added test with class attribute and instance getters/setters that should be prohibited.
relates to #22 and wemake-services#1054

* test:
added new test cases for test_nonmatching_attribute_getter_setter, such that different
types of assignments are tested.
relates to #22 and wemake-services#1054

* refactor:
refactored test_class_mixed to use stacked test parameters to make it easier to test
many combinations. Relates to #22 and wemake-services#1054

* refactor:
added accessor as a new test parameter to ease the creation of
different test combinations for test_nonmatching_attribute_getter_setter and
test_instance_and_class_getter_setter.
Relates to #22 and wemake-services#1054

* refactor:
renamed parameters in test_instance_and_class_getter_setter and test_nonmatching_attribute_getter_setter
to ease readability.
relates to #22 and wemake-services#1054

* test:
added tests that checks that invalid use of class attributes
and getters and setters are prohbited.
Relates to #22, wemake-services#1054

* test:
added test to ensure that class attributes with
non-matching getters and setters is allowed.
relates to #22, wemake-services#1054

* test:
added a test for dataclass that uses explicit getters and setters on
an instance attribute. This should be prohibited. Right now the test
is failing, which indicates that something in the implementation needs to be looked at.
Relates to #22, wemake-services#1054

* Feat: add checks for AnnAssign

* Refactor: rename variable ´asd´ to ´attribute´

* Test: Adds 3 tests

* Refactor: Renames some tests

* Refactor: Cleans up the tests

* Fix: test in wrong location

* Feat: seperate class and instance methods

* Fix: some linter errors

* Test: Moves test and readds deleted test

* test:
added a test that checks that correct use of dataclass with
the propert annotation is allowed
relates to #22 and wemake-services#1054

* Fix: linter violations

Co-authored-by: fwald <38955346+fwald@users.noreply.github.com>
Co-authored-by: ruwaid123 <43616385+ruwaid123@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fwald fwald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fwald