Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jats 'affiliation' and 'relatedto' bugfixes #73

Merged
merged 2 commits into from
Nov 2, 2023
Merged

jats 'affiliation' and 'relatedto' bugfixes #73

merged 2 commits into from
Nov 2, 2023

Conversation

mugdhapolimera
Copy link
Contributor

Fix for poor affiliation parsing in some cases. See #54

Also bugfix for "relatedto" property -- it is now initialized as a list in jats.py

@mugdhapolimera mugdhapolimera linked an issue Oct 27, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7de9dde) 89.06% compared to head (e665e4e) 88.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   89.06%   88.91%   -0.16%     
==========================================
  Files          24       24              
  Lines        2589     2590       +1     
==========================================
- Hits         2306     2303       -3     
- Misses        283      287       +4     
Files Coverage Δ
tests/test_jats.py 95.06% <ø> (ø)
adsingestp/parsers/jats.py 92.02% <75.00%> (-0.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seasidesparrow seasidesparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, simple solution to the affil string issue.

@mugdhapolimera mugdhapolimera merged commit 7dbc4f0 into adsabs:main Nov 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JATS affiliation parsing is poor in certain cases
3 participants