Added drop trigger to alembic ugprade to prevent issue with trigger t… #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rying to write to big_id after name is changed.
tjacovich
commented
Nov 20, 2023
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| def upgrade(): | |||
| op.execute('ALTER TABLE change_log ADD COLUMN big_id BIGINT;') | |||
| op.execute('CREATE FUNCTION set_new_id() RETURNS TRIGGER AS\n'\ | |||
| op.execute('CREATE OR REPLACE FUNCTION set_new_id() RETURNS TRIGGER AS\n'\ | |||
There was a problem hiding this comment.
Added this just so this doesn't error out if the function already exists for some reason.
tjacovich
commented
Nov 20, 2023
| @@ -38,18 +38,21 @@ def upgrade(): | |||
| op.execute("ALTER TABLE change_log RENAME COLUMN big_id TO id;") | |||
| op.drop_column('change_log', 'old_id') | |||
| op.execute('ALTER SEQUENCE change_log_id_seq as bigint MAXVALUE 9223372036854775807') | |||
| op.execute('DROP TRIGGER IF EXISTS set_new_id_trigger ON change_log') | |||
There was a problem hiding this comment.
Added this because writes will fail if the trigger still exists because the column big_id no longer exists
kelockhart
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rying to write to big_id after name is changed.