Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use SciXPipelineUtils #26

Merged
merged 2 commits into from
May 26, 2023

Conversation

tjacovich
Copy link
Collaborator

  • Refactored Harvester to remove local s3_methods and utils modules.
  • Added dependency on SciXPipelineUtils.

@tjacovich tjacovich merged commit 86937a9 into adsabs:main May 26, 2023
2 checks passed
@tjacovich tjacovich deleted the Refactor_s3_utils branch May 26, 2023 21:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5095181939

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 84.256%

Totals Coverage Status
Change from base Build 5095053402: -0.2%
Covered Lines: 487
Relevant Lines: 578

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5095181939

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 84.256%

Totals Coverage Status
Change from base Build 5095053402: -0.2%
Covered Lines: 487
Relevant Lines: 578

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants