Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle facility tags without xlink:href #107

Closed
krisbukovi opened this issue Jan 9, 2020 · 0 comments
Closed

Handle facility tags without xlink:href #107

krisbukovi opened this issue Jan 9, 2020 · 0 comments
Assignees

Comments

@krisbukovi
Copy link
Contributor

Some articles have facilities but are missing the xlink:href field which results in "None", see 2016PASP..128e4201C for example.

Facility tags are expected to have the following structure:

<<named-content content-type="facility xlink:href="facilityid">
facility name
</named-content>

however, it is now apparent that there are at least 48 instances where the xlink:href is missing. Per Sergi, we need to keep extracting xlink:href as we are doing now but modify it so that if xlink:href is empty or does not exist (see note below), then we store nothing instead of None (as if the article did not have any facilities).

note: xpath returns None when xlink:href does not exist, but if it is empty xlink:href="" it will return an empty string, so we need to make sure to handle both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant