Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recaptcha verification to the login #142

Open
romanchyla opened this issue Mar 15, 2018 · 2 comments
Open

add recaptcha verification to the login #142

romanchyla opened this issue Mar 15, 2018 · 2 comments

Comments

@romanchyla
Copy link
Contributor

bbb contacts api/accounts/user

https://github.com/adsabs/adsws/blob/master/adsws/accounts/views.py#L377

it sends user and password + csrf token; for an unknown reason, we never put in the recaptcha - which is present in the registration; we should add it, that requires changes in the class referenced above + change in bbb

https://github.com/adsabs/adsws/blob/master/adsws/accounts/views.py#L499

and corresponding change in bbb, probably here:

https://github.com/adsabs/bumblebee/blob/master/src/js/widgets/authentication/widget.js

@marblestation
Copy link
Contributor

Are we sure about this? It is not common to have captchas to login and it is very annoying when for some non-obvious reason (e.g., you are behind a proxy and there are too many requests) suddenly you have to find cars on an image (or similar tests), wouldn't the current rate limit be enough?

@romanchyla
Copy link
Contributor Author

romanchyla commented Mar 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants