Stop sending extra empty search request

Requests for citation_count being sent even if not sorting by citations, this will now stop those requests
adsabs · Nov 19, 2020 · 0a5c537 · 0a5c537
1 parent 06a3d1d
commit 0a5c537
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/js/widgets/search_bar/search_bar_widget.js b/src/js/widgets/search_bar/search_bar_widget.js
@@ -863,20 +863,22 @@ define([
 
     dispatchRequest: function(apiQuery) {
       var sort = apiQuery.get('sort');
-      var da = this.defaultQueryArguments;
       if (/citation_count_norm/i.test(sort)) {
-        da = _.extend(da, {
+        this.defaultQueryArguments = _.extend(this.defaultQueryArguments, {
           stats: 'true',
           'stats.field': 'citation_count_norm',
         });
       } else if (/citation_count/i.test(sort)) {
-        da = _.extend(da, {
+        this.defaultQueryArguments = _.extend(this.defaultQueryArguments, {
           stats: 'true',
           'stats.field': 'citation_count',
         });
       } else {
         this.model.unset('citationCount');
         this.model.unset('citationLabel');
+
+        // don't bother sending request
+        return;
       }
       BaseWidget.prototype.dispatchRequest.call(this, apiQuery);
     },