Skip to content

Commit

Permalink
Remove coveralls upload from grunt to separate GitHub Action step
Browse files Browse the repository at this point in the history
  • Loading branch information
Nemanja Martinovic committed May 4, 2021
1 parent 87d1d10 commit 5143820
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/ci_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,10 @@ jobs:
- run: npm ci
- run: grunt setup
- run: grunt test:prod
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Coveralls
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
path-to-lcov: "test/coverage/reports/lcov/lcov.info"

1 change: 0 additions & 1 deletion grunt/aliases.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ test:prod:
- server:once
- puppet:prod
- coverage-report:coveralls
- exec:coveralls-report

test:
- clean:temp
Expand Down
4 changes: 0 additions & 4 deletions grunt/exec.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ module.exports = {
'nyc-instrument': {
cmd: 'node_modules/.bin/nyc instrument dist/js/ test/coverage/instrument',
},
'coveralls-report': {
cmd:
'cat test/coverage/reports/lcov/lcov.info | ./node_modules/coveralls/bin/coveralls.js || true',
},
server: 'node server',
suit_build: {
cwd: './src/shared',
Expand Down

0 comments on commit 5143820

Please sign in to comment.