Merge pull request #2167 from shinyichen/sidebar

adsabs · May 22, 2021 · e2083a8 · e2083a8
2 parents 9f4c445 + 2409501
commit e2083a8
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/js/mixins/side_bar_manager.js b/src/js/mixins/side_bar_manager.js
@@ -23,7 +23,9 @@ define(['backbone', 'js/components/api_feedback'], function(
           .getObject('User')
           .getUserData();
         if (!ud) return false;
-        return /show/i.test(ud.defaultHideSidebars);
+        return !ud.defaultHideSidebars
+          ? false
+          : /show/i.test(ud.defaultHideSidebars);
       } catch (e) {
         return false;
       }
@@ -66,8 +68,12 @@ define(['backbone', 'js/components/api_feedback'], function(
      */
     _onUserAnnouncement: function(ev, changed) {
       // only update if the changed key was defaultHideSidebars
-      if (_.contains('defaultHideSidebars', _.keys(changed))) {
-        this.setSidebarState(this._getUpdateFromUserData());
+      if (_.contains(_.keys(changed), 'defaultHideSidebars')) {
+        this.setSidebarState(
+          !changed.defaultHideSidebars
+            ? true
+            : /show/i.test(changed.defaultHideSidebars)
+        );
       }
     },