Fix /search(/) redirect and previous page bug #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error occurs on the route /search, it defaults back to index page. But this error will happen with any bare (no params) search, so you can get into a loop where the back button is constantly re-pushing the index-page. This now replaces the history entry on error, which should fix it.
thostetler
force-pushed
the
fix-routes
branch
from
e50f3df
to
8eb7a0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code in router that was causing history to skip back 2 when seeing
/searchendpoint and instead allowing those routes to be caught be the normal router handlers.