Hide mouse over dropdown menu if mobile or tablet devices #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thostetler
reviewed
Mar 29, 2021
| /BlackBerry/i, | ||
| /Windows Phone/i, | ||
| ]; | ||
| var isMobileOrTablet = devices.some((d) => |
There was a problem hiding this comment.
This certainly works. However we already have a library bowser that could parse the user agent and provide more coverage.
There is a utility:
Line 56 in a1723ff
or docs here: https://lancedikson.github.io/bowser/docs/index.html
thostetler
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.