Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed library issues #2137

Merged
merged 4 commits into from
Mar 29, 2021
Merged

Fixed library issues #2137

merged 4 commits into from
Mar 29, 2021

Conversation

shinyichen
Copy link
Member

@shinyichen shinyichen commented Mar 25, 2021

This PR addresses the following three issues of library view:

  • When user viewing a public library who is not a collaborator, the edit buttons says “You have none privileges", but allows user to click on “View editing options” and add/remove papers.
    • In this case, when user has no permission, this edit button is removed.
  • When selecting records, the “delete” option appears but the user cannot actually delete any record.
    • Delete button is not shown if user has no edit permission
  • "View library in results page" button is not shown unless user has edit permission
    • Show "View library in results page" button regardless of permission

@shinyichen shinyichen marked this pull request as ready for review March 25, 2021 21:16
Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there is a minor conflict -- can merge any time then

# Conflicts:
#	src/js/widgets/library_individual/templates/library-header.html
@shinyichen shinyichen merged commit 5adeaba into adsabs:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants