-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to full text sources in single column view #2138
Conversation
@thostetler Would you please check if I am placing the observer code in the right place? |
@shinyichen yep abstract page manager is the place to put that. |
Now you guys are just messing with me - two of my 3 siblings are Jennifer
and Tim
and I can't figure out why they would be contributing to bumblebee :-)
…--C
*************************************************************************
Carolyn Stern Grant Astrophysics Data System (ADS)
***@***.*** Center for Astrophysics
617-495-7154 (voicemail) 60 Garden Street MS 83
617-495-7356 fax Cambridge, MA 02138
*************************************************************************
On Tue, Apr 6, 2021 at 5:07 PM Tim Hostetler ***@***.***> wrote:
@shinyichen <https://github.com/shinyichen> yep abstract page manager is
the place to put that.
This looks good so far to me
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2138 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKDRFJHH2SSITI2634HILTTHNZY5ANCNFSM42POHRQQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good, I just had the one comment about deleting code vs. commenting it out.
Also, I would go ahead and squash some of these commits so you don't have things lingering in an older commit that you revert later.
#app-container { | ||
will-change: transform; | ||
} | ||
// #app-container { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say instead of commenting out code/styles, just delete them here, we'll have a record in the blame to get it back if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed commented out code and squashed related commits
c80c75b
to
8b3b669
Compare
LGTM, I'll merge |
1. When in single column, the full text sources and data widget is no longer at the bottom of the page, but hidden as a drawer. Use the full text sources button to slide out.
2. Drawer slides out from right side
3. When scrolled up, the menu becomes stick on top
4. The navigation menu is similar