Link to full text sources in single column view #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thostetler Would you please check if I am placing the observer code in the right place? |
|
@shinyichen yep abstract page manager is the place to put that. |
|
Now you guys are just messing with me - two of my 3 siblings are Jennifer
and Tim
and I can't figure out why they would be contributing to bumblebee :-)
…--C
*************************************************************************
Carolyn Stern Grant Astrophysics Data System (ADS)
***@***.*** Center for Astrophysics
617-495-7154 (voicemail) 60 Garden Street MS 83
617-495-7356 fax Cambridge, MA 02138
*************************************************************************
On Tue, Apr 6, 2021 at 5:07 PM Tim Hostetler ***@***.***> wrote:
@shinyichen <https://github.com/shinyichen> yep abstract page manager is
the place to put that.
This looks good so far to me
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2138 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKDRFJHH2SSITI2634HILTTHNZY5ANCNFSM42POHRQQ>
.
|
thostetler
reviewed
Apr 7, 2021
| #app-container { | ||
| will-change: transform; | ||
| } | ||
| // #app-container { |
There was a problem hiding this comment.
I would say instead of commenting out code/styles, just delete them here, we'll have a record in the blame to get it back if necessary
There was a problem hiding this comment.
Removed commented out code and squashed related commits
shinyichen
force-pushed
the
fullTextLink2
branch
from
c80c75b
to
8b3b669
Compare
|
LGTM, I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. When in single column, the full text sources and data widget is no longer at the bottom of the page, but hidden as a drawer. Use the full text sources button to slide out.
2. Drawer slides out from right side
3. When scrolled up, the menu becomes stick on top
4. The navigation menu is similar