Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add orcid icon and link to orcid search from abstract page #2155

Merged
merged 5 commits into from
May 19, 2021
Merged

Add orcid icon and link to orcid search from abstract page #2155

merged 5 commits into from
May 19, 2021

Conversation

shinyichen
Copy link
Member

@shinyichen shinyichen commented Apr 28, 2021 •
edited
Loading

In abstract page, add orcid icon next to author and link to orcid search
The orcid used is based on this priority:

  1. orcid_pub
  2. orcid_user
  3. orcid_other
    Screen Shot 2021-04-29 at 6 59 59 AM

@shinyichen shinyichen marked this pull request as draft April 29, 2021 13:57
@shinyichen shinyichen marked this pull request as ready for review April 30, 2021 17:11
thostetler
thostetler approved these changes May 18, 2021
View reviewed changes
src/js/widgets/abstract/widget.js Outdated Show resolved Hide resolved
src/js/widgets/abstract/widget.js Outdated Show resolved Hide resolved
@thostetler
Copy link
Member

@shinyichen this LGTM -- merge when ready

@shinyichen shinyichen merged commit ced0e1f into adsabs:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thostetler thostetler thostetler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shinyichen @thostetler