Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode #2161

Closed
wants to merge 8 commits into from
Closed

Dark mode #2161

wants to merge 8 commits into from

Conversation

shinyichen
Copy link
Member

@shinyichen shinyichen commented May 5, 2021 •
edited
Loading

  • Added a dark mode switch on the right lower corner
  • Remembers the setting in the local storage
  • Uses system level dark mode preference if dark mode app setting not detected
  • Dark mode CSS is applied based on data-theme attribute in the body tag.
  • Dark mode CSS does not affect original CSS

Screen Shot 2021-05-12 at 4 12 57 PM

Screen Shot 2021-05-12 at 4 15 35 PM

Screen Shot 2021-05-12 at 4 16 24 PM

@shinyichen shinyichen force-pushed the dark branch 3 times, most recently from 521dae6 to 60a65dc Compare May 12, 2021 19:16
@shinyichen shinyichen closed this May 18, 2021
@shinyichen shinyichen deleted the dark branch May 18, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shinyichen