Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version to latest LTS #2199

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

thostetler
Copy link
Member

Also add back in grunt/requirejs.js so that build passes.

Removes unnecessary 'use strict'; directives that were constantly giving warnings

@thostetler
Copy link
Member Author

@shinyichen this changes the node version to the latest LTS. Can you confirm that works on your M1 machine?
You should be able to just do nvm use inside the directory, and it'll pick up the version from the .nvmrc

Thanks!

Copy link
Member

@shinyichen shinyichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and no problem.

@thostetler thostetler merged commit 47820be into adsabs:master Aug 30, 2021
@thostetler thostetler deleted the update-node-version-to-lts branch August 30, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants