Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated search examples #2211

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Conversation

shinyichen
Copy link
Member

  • Use random search examples
  • Removed three links on landing page

@@ -54,51 +54,56 @@ define([
tooltip: PropTypes.string,
};

const SearchExamples = () => {
const SearchExamples = React.memo(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const SearchExamples = React.memo(() => {
const SearchExamples = () => {

I think we can get rid of React.memo here since there aren't any props to compare it against, it'll just re-render everytime anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because it was updating the examples when I click on one of the examples. But it feels very odd to see the examples change when clicked on one of them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if there's better way to handle it.

@shinyichen shinyichen merged commit d0c5768 into adsabs:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants