Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated search examples and fixed random generation upper bound #2227

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Updated search examples and fixed random generation upper bound #2227

merged 1 commit into from
Jan 19, 2022

Conversation

shinyichen
Copy link
Member

No description provided.

kelockhart
kelockhart approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@kelockhart kelockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than one small typo! Ready to merge once that's fixed

src/js/react/Recommender/models/searchExamples.js Outdated
'Quick, Lynnae',
'Turtle, Elizabeth',
'Showalter, Mark',
'Howard. Russell',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo - . should be ,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@shinyichen shinyichen merged commit 4eb4dc8 into adsabs:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelockhart kelockhart kelockhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shinyichen @kelockhart