Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge resources and related materials #2228

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Merge resources and related materials #2228

merged 1 commit into from
Jan 25, 2022

Conversation

shinyichen
Copy link
Member

@shinyichen shinyichen commented Jan 21, 2022 •
edited
Loading

  • Combine the two components' UI into one container
  • Use 'toggle' to show and hide long list of related materials
  • Limit the height of the container, and if content is too long use scroll bar

Normal view

Screen Shot 2022-01-21 at 11 30 03 AM

Long list of related materials

Screen Shot 2022-01-21 at 11 28 00 AM

On small screen

Screen Shot 2022-01-21 at 5 00 02 PM

@shinyichen
Copy link
Member Author

@thostetler Ops I still need to fix the tests. Please hold off on reviewing.

@thostetler thostetler merged commit dd1747c into adsabs:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thostetler thostetler Awaiting requested review from thostetler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shinyichen @thostetler