Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resource timeout issue #2229

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Conversation

thostetler
Copy link
Member

As a stopgap measure, this PR adds a seconds CDN fallback URL. For the
time-being removes SRI for external links.
Also improves app loading messages

As a stopgap measure, this PR adds a seconds CDN fallback URL.  For the
time-being removes SRI for external links.
Also improves app loading messages
Copy link
Member

@shinyichen shinyichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app does not start for me, it's looking for the _setTimeout function. Also in tests.

src/js/components/application.js Show resolved Hide resolved
@thostetler
Copy link
Member Author

@shinyichen thanks for checking it out -- should hopefully be all fixed now. Added a few updates also to the optimizer

@thostetler thostetler force-pushed the fix-timeout-issue branch 2 times, most recently from 34d4ebe to c3670e3 Compare January 25, 2022 03:27
Moves config into options
Invokes requirejs directly, instead of generating config
Fixes context errors
Speed improvements
Copy link
Member

@shinyichen shinyichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and didn't have any issues.

@thostetler thostetler merged commit 04ed323 into adsabs:master Jan 25, 2022
@thostetler thostetler deleted the fix-timeout-issue branch January 25, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants