Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'inst' to search quick field. #2231

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Conversation

shinyichen
Copy link
Member

  • Added inst to search quick field.
  • Use a link in its popover description to a full list of institutions, which required changes the logic in closing the popover to handle link clicks.

…popover to handle link clicks in the popover
document.getElementById('query-search-input').focus();
await new Promise((resolve) => setTimeout(resolve, 10));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to use async/await here? versus just doing the remove() in it's own setTimeout ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I was thinking of the sleep() method in Java.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@thostetler thostetler merged commit 5481e1c into adsabs:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants