Updates to favicon #2233
Merged
Updates to favicon #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thostetler
force-pushed
the
fix-favicon
branch
from
bff5a14
to
349ef82
Compare
shinyichen
reviewed
Feb 11, 2022
| @@ -340,9 +340,17 @@ module.exports = function(grunt) { | |||
| './styles/**', | |||
| './*.html', | |||
| './shared/dist/**', | |||
| '!./styles/favicon/**', | |||
There was a problem hiding this comment.
Is this a duplicate of line 347-353?
There was a problem hiding this comment.
Nah, the ! in front removed it from grunt's file selection.
We want to not keep it in the same structure, but flatten the files out at the root level, so I do that in a separate step.
shinyichen
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new SVG file for generating favicon and added all the necessary files.
This also updates the build process to move favicon assets to the root during release builds