Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of records found in library #2245

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Conversation

shinyichen
Copy link
Member

Show a warning when library's record count doesn't match number of records found.
Screen Shot 2022-03-25 at 10 01 29 AM

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the alert. Couple suggestions in the comments

src/js/widgets/library_list/widget.js Outdated Show resolved Hide resolved
@shinyichen shinyichen merged commit 52201ea into adsabs:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants